Skip to content

Added the company and VAT Number values at OPC address #34389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added the company and VAT Number values at OPC address #34389

wants to merge 1 commit into from

Conversation

engcom-Charlie
Copy link
Contributor

@engcom-Charlie engcom-Charlie commented Oct 19, 2021 •
edited
Loading

Description (*)

As mentioned in PR raised this new PR.

Now the company and VAT Number values are getting displayed at OPC address.

Related Pull Requests

magento/partners-magento2b2b#538

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>
    Issue

Manual testing scenarios (*)

  1. Set Store->Configuration->Customer Configuration->Name and Address Options->Show Company to 'Optional'
  2. Set Store->Configuration->Customer Configuration->Create New Account Options->Show VAT Number on Storefront to 'Optional'
  3. Save config
  4. Run: bin/magento cache:clean
  5. Open registration page /customer/account/create/
  6. Create the customer with the company name and add VAT Number (admin->Customers->edit created customer->Addresses->Add/Update Address)
  7. Add any product to the cart and go to the shipping step

image

Before: ✖️ Company name and VAT Id are not visible

image

image

After: ✔️ Company name and VAT Id are visible

image

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 19, 2021

Hi @engcom-Charlie. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@engcom-Charlie engcom-Charlie changed the title 31425-Added the company and VAT Number values at OPC address and crea… 31425-Added the company and VAT Number values at OPC address Oct 19, 2021
@engcom-Charlie engcom-Charlie mentioned this pull request Oct 19, 2021
Closed
6 tasks
@Den4ik Den4ik self-assigned this Oct 19, 2021
@Den4ik Den4ik self-requested a review October 19, 2021 22:28
@engcom-Charlie engcom-Charlie linked an issue Oct 20, 2021 that may be closed by this pull request
[Issue] Adding the company and VAT Number values at OPC address. #31652
Closed
5 tasks
@engcom-Charlie engcom-Charlie changed the title 31425-Added the company and VAT Number values at OPC address Added the company and VAT Number values at OPC address Oct 20, 2021
@engcom-Charlie engcom-Charlie added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Oct 20, 2021
@ishakhsuvarov
Copy link
Contributor

Closing this for now as it seems abandoned.

Please feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Awaiting requested review from Den4ik

Assignees

@Den4ik Den4ik

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Checkout Component: Customer Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Adding the company and VAT Number values at OPC address.
4 participants
@engcom-Charlie @ishakhsuvarov @Den4ik @magento-engcom-team